Twitter github

Where in the world is my Class?

I did some work in 3.3M4 that allows you to flag missing exported packages (quickfix will be in 3.3M5):

In my opinion, the problem with this particular feature is that the default is IGNORE which means most people won’t know about it, therefore won’t use it (except for those people who have felt the pain of forgetting to export a new package). What does the community think there, should the default level be set to WARNING? This would inherently make everyone follow ‘The Eclipse Way’ (best practice ;p?) by exporting all their packages. However, the idealist in me thinks people will be exporting all their packages anyway and marking the proper ones internal. If you have some thoughts on this issue, please comment πŸ™‚

  • Devastatingly Handsome Committer

    The ‘Ignore’ setting is appropriate as the default. Exporting all packages is not a best practice. It is a personal choice between a man and his plug-in and has no bearing whatsoever on the functionality of a plug-in.

    Should they choose to, users can raise it to WARNING/ERROR, at both a global or project level.

    Let it go already πŸ™‚

  • Devastatingly Handsome Committ

    The ‘Ignore’ setting is appropriate as the default. Exporting all packages is not a best practice. It is a personal choice between a man and his plug-in and has no bearing whatsoever on the functionality of a plug-in. Should they choose to, users can raise it to WARNING/ERROR, at both a global or project level.Let it go already πŸ™‚

  • Patrick

    I agree with the previous comment. I generally export a small subset of my packages and I think that’s a valid best practice. If the default was set to “Warning” , I would immediately change it back to “Ignore”.

    What would be cool would be to have the quick fix work when you’re attempting to access a non-exported package from another plug-in. Then you’re making an explicit choice that the package needs to be available outside the plug-in.

  • Patrick

    I agree with the previous comment. I generally export a small subset of my packages and I think that’s a valid best practice. If the default was set to “Warning” , I would immediately change it back to “Ignore”.What would be cool would be to have the quick fix work when you’re attempting to access a non-exported package from another plug-in. Then you’re making an explicit choice that the package needs to be available outside the plug-in.

  • AlBlue

    What about informational as an extra attribute? That way, information is dumped out as info to the problems view, which can be filtered by people if they don’t want to see it. It would be a compromise between ‘warning’ and ‘ignore’.

  • AlBlue

    What about informational as an extra attribute? That way, information is dumped out as info to the problems view, which can be filtered by people if they don’t want to see it. It would be a compromise between ‘warning’ and ‘ignore’.

  • Villane

    I concur with Alex

  • Villane

    I concur with Alex